Add pImpl to several classes #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-kolarik
reviewed
Feb 16, 2024
jan-kolarik
reviewed
Feb 16, 2024
jan-kolarik
reviewed
Feb 16, 2024
|
Since we are changing the API anyway I have also changed RpmSignature::check_package_signature(rpm::Package pkg)to RpmSignature::check_package_signature(const rpm::Package & pkg) |
jan-kolarik
approved these changes
Feb 16, 2024
|
@kontura Please rebase, it's needed after merging the other pimpl PRs. |
In order to allow access to `user_ids` add utility method: `add_user_id()` as protected so that it can be used from `Key`.
Rebased. |
jan-kolarik
merged commit 844c848
into
rpm-software-management:dnf5-5.2.0.0
5 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is into a new dnf5-5.2.0.0 branch to keep the main branch API compatible.
Another part for: #1025
Specifically for
RpmSignatureI am proposing to convert it into a namespace rather than adding apImplto it, it is described in more details in the commit message.